[lxc-devel] [PATCH 1/1] error.c: don't return error if container init signaled

Serge Hallyn serge.hallyn at ubuntu.com
Mon Sep 9 20:35:52 UTC 2013


We log that at INFO level in case it is needed.  However, in a modern
kernel a container which was shut down using 'shutdown' will always
have been signaled with SIGINT.  Making lxc-start return an error to
reflect that seems overkill.

It's *conceivable* that someone is depending on this behavior, so I'm
sending this out for anyone to NACK, but if I hear no complaints I'll
apply.

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
---
 src/lxc/error.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/lxc/error.c b/src/lxc/error.c
index 15e6ab0..46c34bb 100644
--- a/src/lxc/error.c
+++ b/src/lxc/error.c
@@ -50,7 +50,6 @@ extern int  lxc_error_set_and_log(int pid, int status)
 
 	if (WIFSIGNALED(status)) {
 		int signal = WTERMSIG(status);
-		ret = ret + 128 + signal;
 
 		INFO("child <%d> ended on signal (%d)", pid, signal);
 	}
-- 
1.8.3.2





More information about the lxc-devel mailing list