[lxc-devel] [RFC] [PATCH 0/6] Major cgroup logic rewrite

[Serge Hallyn]

Quoting Christian Seiler (christian at iwakd.de):
> Hi Serge,
> 
> > Thanks, Christian.  I did need the trivial white-space-damaged patch below, but
> > with that it built and ran for me, both with %n and default (/lxc/%n) patterns.
> > This was in a nested container, I haven't tested at host level but have no
> > reason to think that would fail if nested worked :)
> > 
> > However I didn't get occasional cgroups left behind - every cgroup was left
> > behind in my case.  I'll take another look.  I am to send acks and push
> > tomorrow.
> 
> I think I found the problem with that... cgroup.c line 907,
> lxc_cgroup_process_info_free_and_remove should call itself recursively,

Yup, I had just found and tested that, works for me :)

> but a C&P error on my end made it call lxc_cgroup_process_info_free
> instead... So only in the first hierarchy are cgroups removed properly,
> in the others they aren't.
> 
> As I said, there are probably still bugs in there. ;-)

I notice lxc-start is always exiting with -1 for me.  But everything
seems to be working... i'll start looking for the cause of that.