[lxc-devel] [PATCH] lua: fix logic to enable lua support in configure

Natanael Copa ncopa at alpinelinux.org
Fri Sep 6 09:10:49 UTC 2013


On Fri, 6 Sep 2013 10:56:09 +0200
Thomas Moschny <thomas.moschny at gmail.com> wrote:

> 2013/9/6 Natanael Copa <ncopa at alpinelinux.org>:
> > I wonder it it would be an idea to replace the 2 switches:
> >
> >   --enable-lua
> >   --with-lua-pc[=PKG]
> >
> > with a single switch:
> >
> >   --with-lua[=PKG]
> >
> > As it works now, if you specify either --enable-lua or --with-lua-pc,
> > lua will be enabled and configure will fail if Lua headers is missing.
> > Even '--disable-lua --with-lua-pc' will actually enable Lua.
> 
> Having only one switch would absolutely make sense imho.

It will break for users/scripts that currently rely on --enable-lua,
but I think it is ok since its not included in any release.

I have a patch for it ready but will wait til the bugfix patch is
applied.

-nc




More information about the lxc-devel mailing list