[lxc-devel] [PATCH] lua: prepare for Lua 5.2

Dwight Engen dwight.engen at oracle.com
Thu Sep 5 14:20:28 UTC 2013


On Thu, 5 Sep 2013 15:55:16 +0200
Natanael Copa <ncopa at alpinelinux.org> wrote:

> On Thu, 5 Sep 2013 09:34:14 -0400
> Dwight Engen <dwight.engen at oracle.com> wrote:
> 
> > On Thu, 5 Sep 2013 08:11:57 -0500
> > Serge Hallyn <serge.hallyn at ubuntu.com> wrote:
> > 
> > > Hi Dwight,
> > > 
> > > do you have time to review/ack these (3, so far) lua patches?
> > > 
> > > (I probably don't know enough to do so)
> > 
> > Yeah I've taken a look. I had already done an update similar to the
> > first two and was just getting ready to post after some more
> > testing.
> > 
> > Natanael, would you mind taking a look at how I did the update and
> > see if it works for you? I've integrated the fixes you've done into
> > what I had, but I did the autoconf stuff a bit different (the
> > INSTALL_[CL]MOD pkg-config variables don't exist on Fedora/Oracle
> > so I did it more like lua-filesystem does) and also had to fix up
> > that there is no lxc subdir in cgroup anymore.
> 
> Yes, but i verified that fedora has the V variable. The patch I sent
> should fall back to $libdir/lua/$LUA_VERSION and
> $datadir/lua/$LUA_VERSION if INSTALL_[CL]MOD is missing. I tested on
> my local workstation to remove the INSTALL_[CL]MOD from the lua.pc
> file.

Yeah I looked at doing it that way at first too, it does have both V and
R, but then I looked at how lua-filesystem did it and I think its
simpler and cleaner. Also, lua5.1.pc on Ubuntu does not have V, so
what you have wouldn't work there.

> Getting Lua correct is tricky... :-/

Indeed, especially cross distro

> -nc





More information about the lxc-devel mailing list