[lxc-devel] [lxc/lxc] 4e03ae: fix free() of args to startl

GitHub noreply at github.com
Tue Oct 29 18:55:13 UTC 2013


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 4e03ae57eddef788856415673b6d9bc0e3370795
      https://github.com/lxc/lxc/commit/4e03ae57eddef788856415673b6d9bc0e3370795
  Author: Dwight Engen <dwight.engen at oracle.com>
  Date:   2013-10-29 (Tue, 29 Oct 2013)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  fix free() of args to startl

Coverity 1076328 marked this as "Use after free", which it isn't really,
its actually just free()ing the wrong 2nd, 3rd, etc... pointers. Test by
passing two or more args to startl, without this change you get segfault
when free()ing the second pointer/arg.

Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 50266dc604ac8df63328e84376414de7448869b1
      https://github.com/lxc/lxc/commit/50266dc604ac8df63328e84376414de7448869b1
  Author: Dwight Engen <dwight.engen at oracle.com>
  Date:   2013-10-29 (Tue, 29 Oct 2013)

  Changed paths:
    M src/lxc/cgroup.c

  Log Message:
  -----------
  coverity 1097618: check for NULL return from calloc before deref

Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/9588a6cecb4d...50266dc604ac


More information about the lxc-devel mailing list