[lxc-devel] [lxc/lxc] 8daccd: parse.c: don't print error message on callback rv ...

GitHub noreply at github.com
Fri Oct 18 16:28:07 UTC 2013


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 8daccdb4d07d135f65516f095bb63e2bc988f208
      https://github.com/lxc/lxc/commit/8daccdb4d07d135f65516f095bb63e2bc988f208
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2013-10-18 (Fri, 18 Oct 2013)

  Changed paths:
    M src/lxc/parse.c

  Log Message:
  -----------
  parse.c: don't print error message on callback rv > 0

A callback return value < 0 means there was an error, so print
out an error message.  But a rv > 0 is used by the mount_unknown_fs
functions to say "we found the one we want, stop here."

Document this, and only print an error message if rv < 0.  Otherwise,

	lxc-create -B lvm --fstype ext3 -t ubuntu -n u1

will print an (innocuous) error message about being unable to parse
the config value 'ext3'.

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 3ca91fb6f4e648f210096765002404e2d8116c8e
      https://github.com/lxc/lxc/commit/3ca91fb6f4e648f210096765002404e2d8116c8e
  Author: Serge Hallyn <serge.hallyn at ubuntu.com>
  Date:   2013-10-18 (Fri, 18 Oct 2013)

  Changed paths:
    M src/tests/lxc-test-ubuntu

  Log Message:
  -----------
  lxc-test-ubuntu: also allow the standard non-nested apparmor policy

Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/6e7e54d902c7...3ca91fb6f4e6


More information about the lxc-devel mailing list