[lxc-devel] [lxc/lxc] 956f23: python3: Add snapshot_* to the binding

GitHub noreply at github.com
Fri Nov 29 15:43:55 UTC 2013


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 956f23e332bf470cdacccf40966e41f972bb48ac
      https://github.com/lxc/lxc/commit/956f23e332bf470cdacccf40966e41f972bb48ac
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2013-11-29 (Fri, 29 Nov 2013)

  Changed paths:
    M src/python-lxc/lxc.c

  Log Message:
  -----------
  python3: Add snapshot_* to the binding

Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


  Commit: a15877ce8046438a84b8301e1970dfc2c7c409e0
      https://github.com/lxc/lxc/commit/a15877ce8046438a84b8301e1970dfc2c7c409e0
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2013-11-29 (Fri, 29 Nov 2013)

  Changed paths:
    M src/python-lxc/lxc.c

  Log Message:
  -----------
  python3: Allow setting daemonize and close_fds

This extends the list of arguments of start() allowing the user to
request the container be started in the foreground and have control on
whether fds will be closed or not (daemonize=True implies that too).

One problem at the moment however is that while we have functions to set
close_fds and daemonize in the API, we don't have functions to unset
those flags, so those new parameters will only work on the initial call
to start() any further call will use the values of the previous one.

I think it'd make sense to change lxcapi slightly to have daemonize and
close_fds offer a similar interface, both returning booleans and both
accepting a value as a parameter so API users can set the value they
want.

Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/98e5ba5156d4...a15877ce8046


More information about the lxc-devel mailing list