[lxc-devel] [PATCH 5/9] lxc_user_nic: report failing filename in open_and_lock error cases

[Stéphane Graber]

On Tue, Nov 19, 2013 at 04:17:48PM +0000, Serge Hallyn wrote:
> From: Serge Hallyn <serge.hallyn at ubuntu.com>
> 
> Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>

Acked-by: Stéphane Graber <stgraber at ubuntu.com>

> ---
>  src/lxc/lxc_user_nic.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/lxc/lxc_user_nic.c b/src/lxc/lxc_user_nic.c
> index 0b82a50..4154e83 100644
> --- a/src/lxc/lxc_user_nic.c
> +++ b/src/lxc/lxc_user_nic.c
> @@ -105,7 +105,8 @@ int open_and_lock(char *path)
>  
>  	fd = open(path, O_RDWR|O_CREAT, S_IWUSR | S_IRUSR);
>  	if (fd < 0) {
> -		perror("open");
> +		fprintf(stderr, "Failed to open %s: %s\n",
> +			path, strerror(errno));
>  		return(fd);
>  	}
>  
> @@ -114,7 +115,8 @@ int open_and_lock(char *path)
>  	lk.l_start = 0;
>  	lk.l_len = 0;
>  	if (fcntl(fd, F_SETLKW, &lk) < 0) {
> -		perror("fcntl lock");
> +		fprintf(stderr, "Failed to lock %s: %s\n",
> +			path, strerror(errno));
>  		return -1;
>  	}
>  
> -- 
> 1.8.3.2
> 
> 
> ------------------------------------------------------------------------------
> Shape the Mobile Experience: Free Subscription
> Software experts and developers: Be at the forefront of tech innovation.
> Intel(R) Software Adrenaline delivers strategic insight and game-changing 
> conversations that shape the rapidly evolving mobile landscape. Sign up now. 
> http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
> _______________________________________________
> Lxc-devel mailing list
> Lxc-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/lxc-devel

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20131119/66ce5748/attachment.pgp>