[lxc-devel] [lxc/lxc] 287183: add list_all_containers(), returns defined and act...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 2871830a40751c5a8fc30f47a8b8861dfa09d9dc
      https://github.com/lxc/lxc/commit/2871830a40751c5a8fc30f47a8b8861dfa09d9dc
  Author: Dwight Engen <dwight.engen at oracle.com>
  Date:   2013-11-06 (Wed, 06 Nov 2013)

  Changed paths:
    M src/lxc/lxccontainer.c
    M src/lxc/lxccontainer.h

  Log Message:
  -----------
  add list_all_containers(), returns defined and active containers

Changelog: [serge] remove unneeded explicity qsort call

Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: 2c319dbfb562e32ce0ee37a45906ea6370e555b7
      https://github.com/lxc/lxc/commit/2c319dbfb562e32ce0ee37a45906ea6370e555b7
  Author: Dwight Engen <dwight.engen at oracle.com>
  Date:   2013-11-06 (Wed, 06 Nov 2013)

  Changed paths:
    M src/tests/list.c

  Log Message:
  -----------
  tests list: refactor and add test for list_all_containers()

Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: 148a9d276cd256746515068ba0fef7b45a917dfe
      https://github.com/lxc/lxc/commit/148a9d276cd256746515068ba0fef7b45a917dfe
  Author: Dwight Engen <dwight.engen at oracle.com>
  Date:   2013-11-06 (Wed, 06 Nov 2013)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  fix leak in list_active_containers()

Found by running the lxc-test-list test with valgrind. The names were
put into a local array, and never freed in the success case where the
caller didn't want the names returned and in the early out failure case.

Note we don't need to check the return from remove_from_array() because
we just successfully added the name above.

Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/4012c89148c4...148a9d276cd2