[lxc-devel] [PATCH v2 0/4] add statistics to lxc-info

Dwight Engen dwight.engen at oracle.com
Tue Nov 5 18:16:41 UTC 2013


Hi Stéphane,

I was able to add the ***containers output fairly in a fairly
straightforward manner. I also split out the patch into more discrete
logical changes, adding/refactoring the list.c test and fixing a leak in
list_active_containers() along the way. Serge, hopefully you don't mind
I renamed a couple of variables in there that were confusing me :)

Out of curiosity, I'm wondering why we chose to use an array instead of
a list? I suppose its easier for the caller and it does make it easy
to use qsort, but OTOH I guess we could've done sorted inserts into a
list as well. I was thinking about realloc() with a large number of
containers being eventually slow, but I guess its only a bunch of
pointers so it won't ever be all that large of a chunk for realloc to
move. Anyway, its working fine right now.




More information about the lxc-devel mailing list