[lxc-devel] [lxc/lxc] 052616: valgrind drd tool shows conflicting stores happeni...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 052616ebc639aa865c9da3805227cd46618346b6
      https://github.com/lxc/lxc/commit/052616ebc639aa865c9da3805227cd46618346b6
  Author: S.Çağlar Onur <caglar at 10ur.org>
  Date:   2013-11-01 (Fri, 01 Nov 2013)

  Changed paths:
    M configure.ac
    M src/lxc/cgroup.c
    M src/lxc/lxclock.c
    M src/lxc/start.c
    M src/lxc/utils.c
    M src/lxc/utils.h

  Log Message:
  -----------
  valgrind drd tool shows conflicting stores happening at lxc_global_config_value at src/lxc/utils.c (v2)

Conflict occurs between following lines

[...]
269         if (values[i])
270                 return values[i];
[...]

and

[...]
309         /* could not find value, use default */
310         values[i] = (*ptr)[1];
[...]

fix it using a specific lock dedicated to that problem as Serge suggested.

Also introduce a new autoconf parameter (--enable-mutex-debugging) to convert mutexes to error reporting type and to provide a stacktrace when locking fails.

Signed-off-by: S.Çağlar Onur <caglar at 10ur.org>
Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


  Commit: 702154800639285fdfb0f85f8d3e49577871ea25
      https://github.com/lxc/lxc/commit/702154800639285fdfb0f85f8d3e49577871ea25
  Author: S.Çağlar Onur <caglar at 10ur.org>
  Date:   2013-11-01 (Fri, 01 Nov 2013)

  Changed paths:
    M .gitignore

  Log Message:
  -----------
  ignore tags files that can be created via make ctags target

Signed-off-by: S.Çağlar Onur <caglar at 10ur.org>
Signed-off-by: Serge Hallyn <serge.hallyn at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/4de2791fa7dc...702154800639