[lxc-devel] [PATCH 1/3] lxc-stop: use api, remove lxc_shutdown, extend lxc-stop functionality

[Christian Seiler]

Hi,

> [ Christian: this should be a good starting point for adding the
> lxc.signal.{halt,reboot,kill}, etc.  If you don't have time, I'll
> get back to looking at that later.  Thanks! ]

Will do that in the next few days.

> Also if the container is not running, return -2.  Currently
> lxc-stop will return 0, so you cannot tell the difference
> between successfull stopping and noop.

That should be documented in the manpage. Btw. -2 is 254 if you want to
check against it in the shell, since only 8 bits are kept of the return
code.

Also, from looking at lxcapi_shutdown, the -s option currently doesn't
really work, because if timeout > 0, it will always kill the container.

But this is something I can fix in an additional patch on top of that.

-- Christian