[lxc-devel] [PATCH] extend command processor to handle generic data

[Dwight Engen]

On Fri, 17 May 2013 18:23:33 -0500
Serge Hallyn <serge.hallyn at ubuntu.com> wrote:

> Quoting Dwight Engen (dwight.engen at oracle.com):
> > Motivation for this change is to have the ability to get the
> > run-time configuration items from a container, which may differ
> > from its current on disk configuration, or might not be available
> > any other way (for example lxc.network.0.veth.pair). In adding this
> > ability it seemed there was room for refactoring improvements.
> > 
> > Genericize the command infrastructure so that both command requests
> > and responses can have arbitrary data. Consolidate all commands
> > into command.c and name them consistently. This allows all the
> > callback routines to be made static, reducing exposure.
> > 
> > Return the actual allocated tty for the console command. Don't
> > print the init pid in lxc_info if the container isn't actually
> > running. Command processing was made more thread safe by removing
> > the static buffer from receive_answer(). Refactored command
> > response code to a common routine.
> > 
> > Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
> 
> Thanks, Dwight, looks very interesting.  I really want to finish the
> create api tonight/this weekend, but will look at this in detail as
> soon as that's somewhat working.

Hey Serge, no problem not a rush. I'm happy to merge in once you've
got the create api in.