[lxc-devel] create api

[Dwight Engen]

On Wed, 15 May 2013 08:56:27 -0500
Serge Hallyn <serge.hallyn at ubuntu.com> wrote:

> Quoting Dwight Engen (dwight.engen at oracle.com):
> > On Tue, 14 May 2013 14:13:45 -0500
> > Serge Hallyn <serge.hallyn at ubuntu.com> wrote:
> > 
> > > Hi,
> > > 
> > > I'd like to rewrite lxc-create to be c (calling out to the c
> > > templates which continue to be scripts for the most part).
> > > Unfortunately right now the lxcapi_create() just takes arguments
> > > to send to the lxc-create script.
> > > 
> > > I could either dump the existing lxcapi_create function, replace
> > > it with something close to the lxcapi_clone, and update the
> > > current callers, or I can write a new function lxcapi_create2,
> > > keeping lxcapi_create() as calling the c program (which then calls
> > > lxcapi_create2 :).
> > > 
> > > The only reason to go with lxcapi_create2 would be for out of tree
> > > callers (which includes the go bindings).  Since we're not at 1.0
> > > yet we don't guarantee anything about api stability (for exactly
> > > this reason), but I thought I'd ask anyway what you all thought.
> > 
> > I'd vote for trying to keep the API as clean as possible until 1.0,
> > but
> 
> Sorry, I'm not sure on this - by clean do you mean clean it up, or do
> you mean keep it unchanged?

Sorry I wasn't clear: I mean change it so as to keep the API clean and
consistent (ie. don't make an lxcapi_create2, just change lxcapi_create
until 1.0).

> > then I don't have an out of tree caller to update. This brings up a
> > question though, with 1.0 we are going to consider stable the
> > lxcapi_* routines only and not all symbols available from liblxc.so,
> > correct?
> >  
> > > -serge
> >