[lxc-devel] [PATCH 1/6] coverity: free malloc'ed memory in error case

Serge Hallyn serge.hallyn at ubuntu.com
Tue May 7 17:21:58 UTC 2013


Thanks, Dwight.

Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>

to the whole set.

Quoting Dwight Engen (dwight.engen at oracle.com):
> Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
> ---
>  src/lxc/bdev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c
> index 35351a9..1a611f9 100644
> --- a/src/lxc/bdev.c
> +++ b/src/lxc/bdev.c
> @@ -1203,6 +1203,8 @@ static int overlayfs_clonepaths(struct bdev *orig, struct bdev *new, const char
>  			return -ENOMEM;
>  		}
>  		if (do_rsync(odelta, ndelta) < 0) {
> +			free(osrc);
> +			free(ndelta);
>  			ERROR("copying overlayfs delta");
>  			return -1;
>  		}
> -- 
> 1.8.1.4
> 
> 
> 
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and 
> their applications. This 200-page book is written by three acclaimed 
> leaders in the field. The early access version is available now. 
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
> _______________________________________________
> Lxc-devel mailing list
> Lxc-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/lxc-devel




More information about the lxc-devel mailing list