[lxc-devel] [PATCH 6/6] coverity: fix potential dereference NULL returned from malloc

Dwight Engen dwight.engen at oracle.com
Tue May 7 14:57:38 UTC 2013


Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
---
 src/lxc/network.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/lxc/network.c b/src/lxc/network.c
index 93fc169..d1ccc0d 100644
--- a/src/lxc/network.c
+++ b/src/lxc/network.c
@@ -783,8 +783,11 @@ static int ifa_get_local_ip(int family, struct ip_req *ip_info, void** res) {
 
 			/* We might have found an IFA_ADDRESS before,
 			 * which we now overwrite with an IFA_LOCAL. */
-			if (!*res)
+			if (!*res) {
 				*res = malloc(addrlen);
+				if (!*res)
+					return -1;
+			}
 
 			memcpy(*res, RTA_DATA(rta), addrlen);
 
-- 
1.8.1.4






More information about the lxc-devel mailing list