[lxc-devel] [ lxc-Bugs-3612432 ] LXC 0.9.0 fails to build on CentOS6 if -Werror is used

[SourceForge.net]

Bugs item #3612432, was opened at 2013-05-01 12:07
Message generated for change (Tracker Item Submitted) made by robbiesz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=826303&aid=3612432&group_id=163076

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Robert Szabo (robbiesz)
Assigned to: Nobody/Anonymous (nobody)
Summary: LXC 0.9.0 fails to build on CentOS6 if -Werror is used

Initial Comment:
Compilation on CentOS6 (gcc 4.4.6) fails with these two errors:

gcc -DHAVE_CONFIG_H -I. -I../../src    -fPIC -DPIC -I../../src -DLXCROOTFSMOUNT=\"/var/lib/lxc/rootfs\" -DLXCPATH=\"/var/lib/lxc\" -DLXC_GLOBAL_CONF=\"/software/lxc/0.9.0/linux.centos6.x86_64/etc/lxc/lxc.conf\" -DLXCINITDIR=\"/software/lxc/0.9.0/linux.centos6.x86_64/libexec\" -DLXCTEMPLATEDIR=\"/software/lxc/0.9.0/linux.centos6.x86_64/share/lxc/templates\" -DLOGPATH=\"/software/lxc/0.9.0/linux.centos6.x86_64/var/log/lxc\"    -g -O2 -Wall -Werror -MT liblxc_so-conf.o -MD -MP -MF .deps/liblxc_so-conf.Tpo -c -o liblxc_so-conf.o `test -f 'conf.c' || echo './'`conf.c                                                                                                  
cc1: warnings being treated as errors                                                                                                                                                                                         
conf.c: In function 'setup_caps':                                                                                                                                                                                             
conf.c:1725: warning: comparison is always false due to limited range of data type                                                                                                                                            
conf.c:1725: warning: comparison is always false due to limited range of data type                                                                                                                                            
make[4]: *** [liblxc_so-conf.o] Error 1

AND

gcc -DHAVE_CONFIG_H -I. -I../../src    -fPIC -DPIC -I../../src -DLXCROOTFSMOUNT=\"/var/lib/lxc/rootfs\" -DLXCPATH=\"/var/lib/lxc\" -DLXC_GLOBAL_CONF=\"/software/lxc/0.9.0/linux.centos6.x86_64/etc/lxc/lxc.conf\" -DLXCINITDIR=\"/software/lxc/0.9.0/linux.centos6.x86_64/libexec\" -DLXCTEMPLATEDIR=\"/software/lxc/0.9.0/linux.centos6.x86_64/share/lxc/templates\" -DLOGPATH=\"/software/lxc/0.9.0/linux.centos6.x86_64/var/log/lxc\"    -g -O2 -Wall -Werror -MT liblxc_so-caps.o -MD -MP -MF .deps/liblxc_so-caps.Tpo -c -o liblxc_so-caps.o `test -f 'caps.c' || echo './'`caps.c                                                                                                  
cc1: warnings being treated as errors                                                                                                                                                                                         
caps.c: In function '_real_caps_last_cap':                                                                                                                                                                                    
caps.c:204: warning: comparison is always false due to limited range of data type                                                                                                                                             
caps.c:204: warning: comparison is always false due to limited range of data type                                                                                                                                             
make[4]: *** [liblxc_so-caps.o] Error 1

Configuration options:
$ ./configure --prefix=/software/lxc/0.9.0/linux.centos6.x86_64 --with-pic --disable-apparmor --with-config-path=/var/lib/lxc --with-rootfs-path=/var/lib/lxc/rootfs --disable-doc

The attached patch attempts fix these errors by changing the variable type to 'long'.

Rob

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=826303&aid=3612432&group_id=163076