[lxc-devel] [PATCH] EXTRA_DIST: Fix missing files with "make dist"

[Dwight Engen]

On Tue, 26 Mar 2013 13:09:20 -0400
Stéphane Graber <stgraber at ubuntu.com> wrote:

> On 03/26/2013 01:03 PM, Stéphane Graber wrote:
> > I recently noticed that the generated tarballs with "make dist"
> > were incomplete unless the configure script was run on a machine
> > with all possible build dependencies.
> > 
> > That's wrong as you clearly don't need those dependencies to
> > generate the tarball. This change fixes that.
> > 
> > Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
> 
> One file I noticed is included in the main EXTRA_DIST (Makefile.am)
> and I'm not sure whether it should be or not is "lxc.spec".
> 
> The resulting tarball contains both "lxc.spec.in" and "lxc.spec" so in
> theory we don't need "lxc.spec" in there, but I'm not sure whether the
> RPM distros need lxc.spec to trigger the configure and removing it
> would therefore create a chicken-and-egg problem.
> 
> Can someone from one of the RPM distros comment on that?

Hi Stéphane

I believe it is customary to include the .spec in the make dist
tarball. Doing so means users can just download the release tarball and
do rpmbuild -ta lxc-*.tar.gz to build RPMS from it.