[lxc-devel] [PATCH] Use $localstatedir/log/lxc for default log path
Ryota Ozaki
ozaki.ryota at gmail.com
Mon Mar 18 14:48:14 UTC 2013
Hi Serge,
On Mon, Mar 18, 2013 at 10:59 PM, Serge Hallyn <serge.hallyn at ubuntu.com> wrote:
> Quoting Ryota Ozaki (ozaki.ryota at gmail.com):
>> When we install lxc by manual (configure; make; make install),
>> all files are installed under /usr/local/. Configuration files
>> and setting files of containers are stored under /usr/local/ too,
>> however, only log files are stored under /var/log/ not
>> /usr/local/var/log.
>>
>> This patch changes the default log path to $localstatedir/log/lxc
>> (by default $localstatedir is /usr/local/var) where is an ordinary
>> directory, which is probably expected and unsurprising.
>>
>> Signed-off-by: Ryota Ozaki <ozaki.ryota at gmail.com>
>
> Is there any distro which does not use /var/log as the standard
> log location?
Oh I didn't intend to change the log path for distro packages.
Actually when we do "make rpm", the log path will be /var/log/lxc
since $localstatedir is set to /var.
What I want to change with the patch is a behavior when we run
configure without any arguments, which is a procedure that I try
to use latest lxc in git for test.
>
> I don't think treating log files the same way as binaries and
> libraries is the right thing here.
I got surprised that log files are stored under /var/log because
lxc setting files are stored under /usr/local/var/lib (and all other
stuffs are also stored under /usr/local).
One problem that we use a common log path (/var/log) is that
log files for packaged binaries and self-built binaries are mixed.
I want to separate them each other.
Best regards,
ozaki-r
>
>> ---
>> Note that this patch is based on staging of git://github.com/lxc/lxc.git.
>>
>> configure.ac | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 0c94d37..62ddb16 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -194,7 +194,7 @@ AM_CONDITIONAL([USE_CONFIGPATH_LOGS], [test "$use_configpath_logs" = "yes"])
>> if test "$use_configpath_logs" = "yes"; then
>> default_log_path="${with_config_path}"
>> else
>> - default_log_path="/var/log/lxc"
>> + default_log_path="${localstatedir}/log/lxc"
>> fi
>>
>> AC_ARG_WITH([log-path],
>> --
>> 1.8.1.4
>>
>>
>> ------------------------------------------------------------------------------
>> Everyone hates slow websites. So do we.
>> Make your web apps faster with AppDynamics
>> Download AppDynamics Lite for free today:
>> http://p.sf.net/sfu/appdyn_d2d_mar
>> _______________________________________________
>> Lxc-devel mailing list
>> Lxc-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/lxc-devel
More information about the lxc-devel
mailing list