[lxc-devel] [PATCH] console API improvements

[Dwight Engen]

On Mon, 10 Jun 2013 21:24:19 -0500
Serge Hallyn <serge.hallyn at ubuntu.com> wrote:

> > Thanks for the scenario, I tried it here and it is working for me
> > (ie. gnome-terminal, mosh to server, then screen lxc-console -n
> > <ct> -t 0, then resize gnome-terminal). I did see something else
> > though far more concerning: in this scenario resizing the
> > gnome-terminal made lxc-start appear to hang, I gdb'ed it and it
> > was stuck on the read() in start.c:signal_handler. Doing a kill on
> > lxc-start 'un-hung' it, but something is not right, so I'll look
> > into it.
> 
> Hm, tried locally in a gnome-terminal as well as in a xterm, and I
> still don't get window resizes recognized until I disconnect with
> ctrl-a q and then reconnect to the console.  I also tried without an
> apparmor profile and without devices cgroup settings, so that doesn't
> appear to be the problem.
> 
> -serge

Hi Serge, still haven't been able to reproduce the not resizing thing.
I did fix the 'hang' though and it might've been related. Changes in
the v2 patch (to follow) compared to the first version:

 - Reworked signal handling to better integrate with the way start.c is
   doing it (ie. use signalfd). This has a nice benefit in that in the
   signal handling case we don't have to worry about thread locking
   either and so we don't have to think about 'a signal handler locking
   causing a deadlock scenario'.

 - Fixed python api escape character -> 'a'

 - Moved signalfd libc wrapper to utils.h since it will now be used in
   two places