[lxc-devel] [PATCH] add lua binding for the lxc API

[Dwight Engen]

On Tue, 22 Jan 2013 18:39:00 -0500
Stéphane Graber <stgraber at ubuntu.com> wrote:

> On 01/22/2013 11:03 AM, Dwight Engen wrote:
> > The lua binding is based closely on the python binding. Also
> > included are a test program for excercising the binding, and an
> > lxc-top utility for showing statistics on running containers.
> > 
> > Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
> 
> I was just about to ask about the status of your lua bindings when I
> saw that one in my mailbox ;)

Yeah, I meant to send it a bit ago but got busy with other things :)

> I wrote a couple of comments inline below.

Should be addressed in a v2 patch to follow.
 
> I'm also assuming that if we merge this we can count on you to keep
> the binding up to date as we do API changes?
> 
> We try not to break it and I don't think we actually ever broke it
> since it was first pushed to the staging branch, however that may
> still happen until we decide that it's good and release 1.0.

Yes, I intend to keep it up to date. As an aside about the API, while
doing this it was a bit non-obvious is when to use get_keys() vs
get_config_item(). Maybe we need a schema, or perhaps we'll move to
Augeas or something else as Serge mentioned a while back.

[...]
> > diff --git a/Makefile.am b/Makefile.am
> > index 7b32326..89260e5 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -6,6 +6,10 @@ SUBDIRS = config src templates doc
> >  DIST_SUBDIRS = config src templates doc
> >  EXTRA_DIST = autogen.sh lxc.spec CONTRIBUTING MAINTAINERS ChangeLog
> >  
> > +if ENABLE_LUA
> > +RPMARGS = --with lua
> > +endif
> > +
> 
> Should we have something similar for python? (in a separate patch
> obviously)

Yep, thanks for committing this yesterday.
 
[...]
> > diff --git a/src/lua-lxc/Makefile.am b/src/lua-lxc/Makefile.am
> > new file mode 100644
> > index 0000000..3db3b7c
> > --- /dev/null
> > +++ b/src/lua-lxc/Makefile.am
> > @@ -0,0 +1,30 @@
> > +if ENABLE_LUA
> > +
> > +luadir=$(datadir)/lua/5.1
> > +sodir=$(libdir)/lua/5.1/lxc
> > +
> > +lua_SCRIPTS=lxc.lua
> > +EXTRA_DIST=lxc.lua lxc-top
> 
> Any reason not to put lxc-top in src/lxc/ similarly to what was done
> for some of the python-based tools?

I thought (incorrectly) that the python tools in src/lxc/ did not
depend on the python module, which is the why I had kept lxc-top
with the module. I agree its better to put it in src/lxc, done in the
v2 patch.