[lxc-devel] [PATCH] Fix check for openpty

Serge Hallyn serge.hallyn at canonical.com
Mon Jan 14 15:41:18 UTC 2013


Quoting Stéphane Graber (stgraber at ubuntu.com):
> On 01/11/2013 11:17 PM, Serge Hallyn wrote:
> > Quoting Stéphane Graber (stgraber at ubuntu.com):
> >> The previous implementation of the openpty check was always returning
> >> 'no' as openpty is typically defined in util.
> >>
> >> Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
> > 
> > But if I read the docs right
> > (http://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Libraries.html)
> > this will cause HAVE_LIBUTIL to be set...  not HAVE_OPENPTY.
> > 
> > is that what you want?  (or did I misread the docs?)
> 
> The AC_CHECK_LIB call is only there to make the subsequent
> AC_CHECK_FUNCS call succeed for openpty. That seemed a little weird to
> me too, but that's what
> http://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Generic-Functions.html
> says you should do...

Interesting  :)  thanks.

Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>




More information about the lxc-devel mailing list