[lxc-devel] [PATCH] Withdraw: Final: Remove MAKEDEV call, add autodev hooks, add environment variables for hook scripts.

[Michael H. Warfield]

Withdraw!

On Fri, 2013-01-11 at 12:16 -0600, Serge Hallyn wrote:
> Quoting Michael H. Warfield (mhw at WittsEnd.com):
> > Ok...
> > 
> > My patch to deal with the MAKDEV and hook script stuff after discussion
> > and valuable input from Serge.
> > 
> > To reiterate - Does several things (that are closely intertwined so
> > separate patches are not justified)...
> > 
> > 1) Removes run_makedev() and the call to it from conf.c per discussion.
> > 
> > 2) Adds an lxc.hook.autodev hook.
> > 
> > 3) Added a number of environment variables for all the hook scripts to
> > reference to assist in execution.
> > 
> > 4) clearenv and putenv( "container=lxc" ) calls were moved to just after
> > the "start" hook in the container just prior to actually firing up the
> > container so we could use environment variables prior to that and have
> > them flushed them before firing up init.
> > 
> > 5) Documentation updated as appropriate.
> > 
> > Patch below my signature block.  In addition to signing off, this
> > message is PGP signed (as are most of my messages) and, as such,
> > authenticated to me.
> > 
> > Signed-off-by: Michael H. Warfield <mhw at WittsEnd.com>

> Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>

> although we should (this can be a follow-on patch) free the char *rcfile
> in src/lxc/conf.c:lxc_conf_free.  

As I said in other, off list, E-Mail, we have a race.  This patch now
conflicts with your other patch to pull the logfile and loglevel
structure members and this may patch but the result would no longer
compile.  I defer to you.  I'll pull the "loglevel" code as well and
resubmit.

Stephane, please hold off on this one.

> It occurs to me (as I'm doing the userns set right now) that the
> lxc.hook.autodev may become a problem with user namespaces (lxc
> won't know to automatically chown those as it does the normal tty
> devices), but we'll have to sort that out later - or just expect
> the hooks to DTRT.

> 
> ------------------------------------------------------------------------------
> Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and
> much more. Get web development skills now with LearnDevNow -
> 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
> SALE $99.99 this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122812
> _______________________________________________
> Lxc-devel mailing list
> Lxc-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/lxc-devel
> 

-- 
Michael H. Warfield (AI4NB) | (770) 985-6132 |  mhw at WittsEnd.com
   /\/\|=mhw=|\/\/          | (678) 463-0932 |  http://www.wittsend.com/mhw/
   NIC whois: MHW9          | An optimist believes we live in the best of all
 PGP Key: 0x674627FF        | possible worlds.  A pessimist is sure of it!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 482 bytes
Desc: This is a digitally signed message part
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20130112/a692efe4/attachment.pgp>