[lxc-devel] [PATCH] Remove MAKEDEV call, add autodev hooks, add environment variables for hook scripts.

Serge Hallyn serge.hallyn at canonical.com
Fri Jan 11 16:14:09 UTC 2013


Quoting Michael H. Warfield (mhw at WittsEnd.com):
> On Thu, 2013-01-10 at 16:52 -0600, Serge Hallyn wrote:
> > Quoting Michael H. Warfield (mhw at WittsEnd.com):
> > 
> > looks good, one comment (a "you were right" :)
> 
> :-)=)
> 
> [[ Snip ]]
> 
> > Sorry - definately the scripts don't need to know LXC_LOGPATH.  That's
> > only to keep track (in memory) of the logfile that was stored in the
> > rcfile in case it was override with -o in lxc_start.  So actually you're
> > right, I think we should get rid of that variable, just use it (or not)
> > when we see it.  I was thinking we might want to store it in some cases
> > for the api - but then if we're using lxc-start we're not using the api,
> > and we only override at lxc-start.  So no sense storing this.
> 
> Ok...  Concur on the file name / path.  Pretty much what I was thinking
> but I had to be sure.  I'll pull that from the code then and, if that's
> the only comment, I'll sign off on a final version shortly and send my
> patch back in.
> 
> Now...  I do think the "loglevel" / "priority" could still be valuable,
> especially if it's variable ala a signal or such as some persistent
> commands do.  Whether it's from a signal, an API, the config file, or
> the command line, it could still be useful, for debugging purposes, for
> a hook script to know what the logging (or verbosity) level is.  I would
> like to see those welded together.

I've been staring for a few minutes, and I think what I'll do is remove
the two variables from lxc_conf, add lxc_log_get_log{file,level}
functions in log.c, and use those when writing the lxc_conf.

Doing userns right now, but will hopefully get that patch out today.

-serge




More information about the lxc-devel mailing list