[lxc-devel] [PATCH] Remove /dev/kmsg symlinking.

[Serge Hallyn]

Quoting Alexander Vladimirov (alexander.idkfa.vladimirov at gmail.com):
> process_event function in journald
> (http://cgit.freedesktop.org/systemd/systemd/tree/src/journal/journald-server.c#n987)
> handles events differently depending on descriptor type.
> Debugging with gdb showed that /dev/kmsg being a symlink triggers
> "invalid event" error at line 1032
> (http://cgit.freedesktop.org/systemd/systemd/tree/src/journal/journald-server.c#n1032)
> and terminates journald immediately.
> I asked about that error on #systemd and Kay told me that symlinking
> is wrong because /dev/kmsg has specific semantics, that cannot be
> reproduced by /dev/console symlink. Journald has config option to
> forward messages to console other way around and other logging systems
> should be able to do that too.

Yeah, but the point of /dev/kmsg is that anyone (privileged) can write
to it - so by updating where journald writes to, you're certain to miss
some other userspace.  

Anyway, I guess I'm ok with removing setup_kmsg() altogether.

It may push me to address it in the kernel sooner (though it's a time
issue, not a willingness issue).

Stéphane, how much do you rely on the setup_kmsg() kmsg->console hack?

-serge