[lxc-devel] [PATCH] Support MS_SHARED /

[Serge Hallyn]

Quoting Michael H. Warfield (mhw at WittsEnd.com):
> On Sun, 2013-01-06 at 06:39 +0800, Alexander Vladimirov wrote:
> > It is a separate package in Arch Linux and I dont have it installed on
> > the host, as well as in container since everything works well without
> > it
> 
> Well, that would explain it.  What isn't explained is why we need it.

(see my previous response)

> This is the run_makedev() function which is called from setup_autodev()
> in src/lxc/setup.c just before it tries to populate the .../dev
> directory in the container.  There's some comments in there about making
> sure the /dev/vcs* entries are created.

Right.

> It's also not clear to me if it's even doing what it perports to do.  It
> changes to the dev directory and then runs /sbin/MAKEDEV (without
> checking if it even exists)

Right, that should be fixed,

> without a parameter (-d) for the target
> directory which would seem to me to cause MAKEDEV to attempt to create

At least my copy of makedev creates the devices in $cwd.

If adding -d is needed for other distros, of course I have 0 objections.

> the devices in the host /dev and not the container .../dev directory at
> all.  That actually appears consistent with the behavior I'm seeing.  If
> I reboot the host system, all those tty devices do not exist in the host

?  In the host /dev, or in the /var/lib/lxc/$container/rootfs/dev?

If the former, I don't see what the container to do to affect the host's
boot sequence.

> until after I fire up a container with autodev enabled.  Then they
> appear in the host /dev which is not the correct behavior.

No it's not.

> I don't think we should be doing this but this is part of the earlier
> autodev patches Serge did for systemd that went into 9.0.0.a1.  Maybe
> it's a difference in behavior between MAKEDEV on Ubuntu vs MAKEDEV on
> Fedora (et al) and not even guaranteed to exist.

Sounds like it.

> Serge?

-serge