[lxc-devel] [PATCH] only INFO rcfile if asprintf successfully allocates it

Stéphane Graber stgraber at ubuntu.com
Mon Feb 18 20:56:15 UTC 2013


On 02/12/2013 01:13 PM, Serge Hallyn wrote:
> Quoting Dwight Engen (dwight.engen at oracle.com):
>> Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
> 
> Indeed.  thanks :)
> 
> Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>

Pushed to staging. Thanks

>> ---
>>  src/lxc/lxc_start.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/lxc/lxc_start.c b/src/lxc/lxc_start.c
>> index aac7fe7..9d8db63 100644
>> --- a/src/lxc/lxc_start.c
>> +++ b/src/lxc/lxc_start.c
>> @@ -182,12 +182,12 @@ int main(int argc, char *argv[])
>>  		}
>>  
>>  		rc = asprintf(&rcfile, "%s/%s/config", lxcpath, my_args.name);
>> -		INFO("using rcfile %s", rcfile);
>>  		free(lxcpath);
>>  		if (rc == -1) {
>>  			SYSERROR("failed to allocate memory");
>>  			return err;
>>  		}
>> +		INFO("using rcfile %s", rcfile);
>>  
>>  		/* container configuration does not exist */
>>  		if (access(rcfile, F_OK)) {
>> -- 
>> 1.7.12.3
>>
>>
>> ------------------------------------------------------------------------------
>> Free Next-Gen Firewall Hardware Offer
>> Buy your Sophos next-gen firewall before the end March 2013 
>> and get the hardware for free! Learn more.
>> http://p.sf.net/sfu/sophos-d2d-feb
>> _______________________________________________
>> Lxc-devel mailing list
>> Lxc-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/lxc-devel
> 
> ------------------------------------------------------------------------------
> Free Next-Gen Firewall Hardware Offer
> Buy your Sophos next-gen firewall before the end March 2013 
> and get the hardware for free! Learn more.
> http://p.sf.net/sfu/sophos-d2d-feb
> _______________________________________________
> Lxc-devel mailing list
> Lxc-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/lxc-devel
> 


-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20130218/038192de/attachment.pgp>


More information about the lxc-devel mailing list