[lxc-devel] [PATCH] Update Lua API, make default_lxc_path const

Serge Hallyn serge.hallyn at ubuntu.com
Mon Feb 11 21:17:52 UTC 2013


Quoting Dwight Engen (dwight.engen at oracle.com):
> Add [gs]et_config_path from API to Lua binding. Add additional optional
> parameter to container_new(). Add tests for these new Lua API bindings.
> Commit 2a59a681 changed the meaning of lxc_path_get() in the binding,
> causing lua script breakage. Reinstate original behavior of
> lxc_path_get() and rename it to lxc_default_config_path_get() to make
> its intent clearer.
> 
> Reworked default_lxc_path to compute the default path only once and
> return a const char *. Four of the five callers don't need a modifiable
> buffer and this saves us from re-parsing the global config file on

I'd rather wait on trying to optimize this until we have the
lxcpath stuff worked out - that is, until lxcpath is fully
specifiable in every command line tool and api user.

Do you mind if we take the lua part right now, and postpone the
other part (which will conflict with the large patch I just sent)
until later this week or next?

> every call. This also fixes a leak in fill_sock_name().

The patch I just sent a few minutes ago fixed that leak by
just freeing - I don't know where the free had disappeared
to :)

> Signed-off-by: Dwight Engen <dwight.engen at oracle.com>





More information about the lxc-devel mailing list