[lxc-devel] [PATCH] [cosmetic] adjust include statements

Serge Hallyn serge.hallyn at ubuntu.com
Mon Dec 23 19:15:12 UTC 2013


Quoting S.Çağlar Onur (caglar at 10ur.org):
> Hey Serge,
> 
> On Mon, Dec 23, 2013 at 11:09 AM, Serge Hallyn <serge.hallyn at ubuntu.com> wrote:
> >
> > Why?
> 
> I've no good reason to justify this change as it's purely cosmetic.
> That's why I added [cosmetic] keyword to the patch description :)
> 
> > Admittedly if you're a developer this will be what you want, but
> > in general '<lxc/include.h>' would be the more correct way.  Could
> > we instead address this with a -I${topdir}/src in the Makefile, or
> > would that not suffice?
> 
> I have a useless tendency to assume "#include <lxc/something>" style
> is for external headers that live outside of the code and "#include
> "something"" is for the internal ones. Current codebase uses both
> styles and just wanted to standardize.

Yeah and I think I agree with you.

Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>

But before I push it I'd like to leave some time for anyone to
bring up any reasons not to do this.  If noone replies in the next
few days lets go ahead and push (though unfortunately I'll be out the
rest of december)

-serge


More information about the lxc-devel mailing list