[lxc-devel] [lxc/lxc] d2bf79: lxc-clone: proper type for getopt_long result

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: d2bf794591e47bbc2b66a2921440e9e0f0518359
      https://github.com/lxc/lxc/commit/d2bf794591e47bbc2b66a2921440e9e0f0518359
  Author: Bogdan Purcareata <bogdan.purcareata at freescale.com>
  Date:   2013-12-09 (Mon, 09 Dec 2013)

  Changed paths:
    M src/lxc/lxc_clone.c

  Log Message:
  -----------
  lxc-clone: proper type for getopt_long result

While char is a signed type and should have no trouble
storing a "-1" value, getopt_long() will return a value of 255
instead of -1. This has been noticed on powerpc; there's also
some upstream talk about it at [1].

Change variable type from char to int, since it's also the
documented use.

[1] http://stackoverflow.com/questions/17070958/c-why-does-getopt-return-255-on-linux

Signed-off-by: Bogdan Purcareata <bogdan.purcareata at freescale.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


  Commit: 7f1dea04a4045539fa92a7f7cbdbb0d091d6a4d2
      https://github.com/lxc/lxc/commit/7f1dea04a4045539fa92a7f7cbdbb0d091d6a4d2
  Author: Bogdan Purcareata <bogdan.purcareata at freescale.com>
  Date:   2013-12-09 (Mon, 09 Dec 2013)

  Changed paths:
    M templates/lxc-busybox.in

  Log Message:
  -----------
  lxc-busybox: make securityfs bind-mount optional

Prevent container start from failing when running Busybox containers on hosts without securityfs support.

Signed-off-by: Bogdan Purcareata <bogdan.purcareata at freescale.com>
Acked-by: Stéphane Graber <stgraber at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/359c71b65fa1...7f1dea04a404