[lxc-devel] [PATCH 1/5] cgroup: minor bugfixes so start and attach work again

[Christian Seiler]

Hi Serge,

> Ok, how about we make the system-cgroup-dir configurable in
> /etc/lxc/lxc.conf?  So if you have
>
> 	lxc.system-cgroup-dir = /machine
>
> then root-created containers will end up in /machine (or, if you're
> already nested under /lxc/m1, then /lxc/m1/machine).  If that is
> unset or /, then you're placed in root cgroup.  If you're not
> root, then you end up under your current cgroup (assuming you
> have rights to create them, which you won't for some)
>
> Does that seem reasonable?

Yes, but maybe we could generalize it a bit more:

lxc.system-cgroup-pattern = /lxc/%s
      -> $init_cgroup/lxc/foo
lxc.system-cgroup-pattern = /machine/%s.lxc
      -> $init_cgroup/machine/foo.lxc
lxc.system-cgroup-pattern = %s
      -> $current_cgroup/foo

For non-root, I agree, it should be under your current cgroup.

Thoughts?

-- Christian