[lxc-devel] [PATCH 1/5] cgroup: minor bugfixes so start and attach work again

[Serge Hallyn]

Quoting Christian Seiler (christian at iwakd.de):
> Hi Serge,
> 
> >If we're going to do this, we should do it soon.  Would you have time
> >in the next few days?
> 
> Define 'few'. ;) I should be able to do that until Monday (barring any
> emergencies).
> 
> >(BTW, if we're going to throw words like b0rked around, I'd prefer to
> >reserve that for the refusal to implement fake-root in cgroups itself
> >which would allow us to ignore this by treating ourselves as really
> >being inside '/')
> 
> Sorry, I didn't mean any insult by that. But yes, virtualized cgroups
> would obviously be the best solution.[tm]
> 
> 
> 
> Two technical questions:
> 
>  1. What about the naming convention? Stick with /lxc/$name or go with
>     /machine/$name.lxc (see prev. email)? Or I could make that
>     configurable?

$name.lxc or lxc.$name seems good for all cases.  It'll benefit
unprivileged users also.  By "/machine/$name.lxc" did you actually
mean under the /machine group?  If we add lxc as a prefix or suffix,
do you think that suffices for the grouping?

>  2. Any objections to implementing the mountcgroups hook in C?
>     Especially if I want to do the cgroup mount point detection right
>     (and not just assume /sys/fs/cgroup) it is going to be a huge pain
>     to do that in shell, whereas in C I could reuse code.

Nope - it'll require a hooks/Makefile.am tweak, is all.  I was
using scripts originally to encourage people to hack on them,
but I'm not sure people are doing that anyway.  (If we wanted
to continue supporting that then we might want to use python)