[lxc-devel] [PATCH 1/5] cgroup: minor bugfixes so start and attach work again

[Serge Hallyn]

Quoting Stéphane Graber (stgraber at ubuntu.com):
> On Mon, Aug 19, 2013 at 04:57:10PM -0500, Serge Hallyn wrote:
> > Quoting Christian Seiler (christian at iwakd.de):
> > > Hi Serge,
> > > 
> > > > Thanks, Christian - I've pushed a new patch to github on top of yours.
> > > > Regular start/stop/lxc-cgroup stuff is working for me both with all
> > > > cgroups composed and separately mounted.
> > > 
> > > I can confirm that it works on my setup.
> > > 
> > > I do have a very stupid question, however: LXC 0.9 used to set the
> > > cgroup to /lxc/$name. Now it's just /$name. Is that intentional?
> > 
> > Hm, it was somewhat unconscious but I didn't really mean to do that.
> > Some cgroup subsystems do incur a performance penalty for every
> > extra directory we descend.  But /lxc does make for a nice grouping.
> > 
> > Do you (and others) have a preference?  Should we stick with /lxc?
> > 
> > -serge
> 
> Having /lxc makes it much easier to sett what's part of a container vs
> what's part of a user session or whatever else uses cgroups these days.

Note that nothing stops you from simply entering cgroup /lxc by hand
before executing a container.  Right now the code simply puts you into
a child of whichever directory you are in.  Advantage is slightly
simpler code.