[lxc-devel] [PATCH 05/17] Android now uses a sane clone() definition

[Stéphane Graber]

On Fri, Aug 16, 2013 at 10:26:29AM -0500, Serge Hallyn wrote:
> Quoting Stéphane Graber (stgraber at ubuntu.com):
> > The current Android NDK provides a clone() defintion that's identical to
> 
> Does this mean this will break older androids?  Or is that not how it
> works?

Maybe, I'm not really sure about that one, but maintaining compatibility
with multiple version of bionic is a real pain (considering they're not
really numbered and we can't easily test that in autoconf). So I believe
the current NDK should be fine for at least 4.3 and 4.2. I'll know more
once I can do some more testing on my Android phone back home...

> 
> > eglibc's so we can drop the ifdef from that one.
> > 
> > Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
> 
> Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>
> 
> > ---
> >  src/lxc/namespace.h | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/src/lxc/namespace.h b/src/lxc/namespace.h
> > index c6a97ec..0c53630 100644
> > --- a/src/lxc/namespace.h
> > +++ b/src/lxc/namespace.h
> > @@ -53,9 +53,6 @@
> >  #if defined(__ia64__)
> >  int __clone2(int (*__fn) (void *__arg), void *__child_stack_base,
> >               size_t __child_stack_size, int __flags, void *__arg, ...);
> > -#elif defined(IS_BIONIC)
> > -int clone(int (*fn)(void *), void *child_stack,
> > -	int flags, void *arg);
> >  #else
> >  int clone(int (*fn)(void *), void *child_stack,
> >  	int flags, void *arg, ...
> > -- 
> > 1.8.3.2
> > 
> > 
> > ------------------------------------------------------------------------------
> > Get 100% visibility into Java/.NET code with AppDynamics Lite!
> > It's a free troubleshooting tool designed for production.
> > Get down to code-level detail for bottlenecks, with <2% overhead. 
> > Download for free and get started troubleshooting in minutes. 
> > http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Lxc-devel mailing list
> > Lxc-devel at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/lxc-devel

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20130816/7ec34292/attachment.pgp>