[lxc-devel] [PATCH 8/8] attach: implement remaining options of lxc_attach_set_environment

[Christian Seiler]

Hi Serge,

>>> The freeing seems unnecessary as you're about to rexit(-1), right?
>>
>> in the current flow, yes. However, this function may be useful from
>> other places where one does not exit if it fails, so I'd rather be a bit
>> defensive in the programming style, if possible.
> 
> In that case should you also free if the clearenv() fails?

Oh, yes, I missed that. I'll can post a follow-up patch or resend,
whatever is more convenient for you.

-- Christian