[lxc-devel] [PATCH] Improve check for systemd in the template for Fedora

[Serge Hallyn]

Quoting Michael H. Warfield (mhw at WittsEnd.com):
> On Tue, 2013-08-13 at 20:57 -0500, Serge Hallyn wrote: 
> > The current code is testing for systemd on the host.  That's not right.
> > You're right that checking for the running systemd in the guest isn't
> > right either :)
> > 
> > So I'd say the thing to do is
> 
> > ...
> > > > diff --git a/templates/lxc-fedora.in b/templates/lxc-fedora.in
> > > > index 23728c6..36c3d21 100644
> > > > --- a/templates/lxc-fedora.in
> > > > +++ b/templates/lxc-fedora.in
> > > > @@ -567,7 +567,7 @@ if [ $? -ne 0 ]; then
> > > >      exit 1
> > > >  fi
> > > 
> > > > -type /bin/systemd >/dev/null 2>&1
> 
> > replace that with checking for $rootfs/bin/systemd as
> > well as $rootfs/usr/bin/systemd?
> 
> That's just what I've been thinking.  It may not be perfectly optimal
> but I think it's the best we can expect.  And, yes, lets check them
> both.

Ok - who wants to send the new patch?  :)

thanks,
-serge