[lxc-devel] [PATCH] lxc-wait should start monitord

[Dwight Engen]

On Thu, 25 Apr 2013 18:20:13 +0200
Stéphane Graber <stgraber at ubuntu.com> wrote:

> On 04/25/2013 06:05 PM, Serge Hallyn wrote:
> > Quoting Dwight Engen (dwight.engen at oracle.com):
> >> On Thu, 25 Apr 2013 10:40:24 -0500
> >> Serge Hallyn <serge.hallyn at ubuntu.com> wrote:
> >>
> >>> Quoting Dwight Engen (dwight.engen at oracle.com):
> >>>> If lxc-wait is run before the container the socket will not yet
> >>>> have been created and lxc_wait's connect to it will fail.
> >>>>
> >>>> Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
> >>>
> >>> Oh, yeah, I was thinking it happened in the common code magically.
> >>
> >> Hmm, that makes me think of lxcapi_wait(), it won't be done there
> >> either. Do we want it there also, or should we think of putting it
> >> in lxc_wait() which would handle both cases?
> > 
> > Good point. In lxc_wait is probably better.
> > 
> > (Stéphane, please don't apply this patch :)
> 
> Hehe, I "almost" applied the patch but got interrupted by something
> else and then noticed your e-mail in my work mailbox ;)

Whew, glad you mentioned magical common code Serge :) I think v2 is
now in the right place.