[lxc-devel] [PATCH] lxc-wait should start monitord

Dwight Engen dwight.engen at oracle.com
Thu Apr 25 15:51:08 UTC 2013


On Thu, 25 Apr 2013 10:40:24 -0500
Serge Hallyn <serge.hallyn at ubuntu.com> wrote:

> Quoting Dwight Engen (dwight.engen at oracle.com):
> > If lxc-wait is run before the container the socket will not yet have
> > been created and lxc_wait's connect to it will fail.
> > 
> > Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
> 
> Oh, yeah, I was thinking it happened in the common code magically.

Hmm, that makes me think of lxcapi_wait(), it won't be done there
either. Do we want it there also, or should we think of putting it in
lxc_wait() which would handle both cases?

> Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>
> 
> > ---
> >  src/lxc/lxc_wait.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/src/lxc/lxc_wait.c b/src/lxc/lxc_wait.c
> > index 18200e5..b2e6c0a 100644
> > --- a/src/lxc/lxc_wait.c
> > +++ b/src/lxc/lxc_wait.c
> > @@ -87,5 +87,10 @@ int main(int argc, char *argv[])
> >  			 my_args.progname, my_args.quiet))
> >  		return -1;
> >  
> > +	if (lxc_monitord_spawn(my_args.lxcpath) < 0) {
> > +		ERROR("failed to spawn monitor daemon");
> > +		return -1;
> > +	}
> > +
> >  	return lxc_wait(strdup(my_args.name), my_args.states,
> > my_args.timeout, my_args.lxcpath); }
> > -- 
> > 1.8.1.4
> > 
> > 
> > ------------------------------------------------------------------------------
> > Try New Relic Now & We'll Send You this Cool Shirt
> > New Relic is the only SaaS-based application performance monitoring
> > service that delivers powerful full stack analytics. Optimize and
> > monitor your browser, app, & servers with just a few lines of code.
> > Try New Relic and get this awesome Nerd Life shirt!
> > http://p.sf.net/sfu/newrelic_d2d_apr
> > _______________________________________________ Lxc-devel mailing
> > list Lxc-devel at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/lxc-devel





More information about the lxc-devel mailing list