[lxc-devel] [PATCH 1/2] init: unnest interrupt_handler

[Serge Hallyn]

Quoting Richard Weinberger (richard at nod.at):
> There is no need to use nested functions voodoo.

I see no downside to this, but what is the upside?

> Signed-off-by: Richard Weinberger <richard at nod.at>
> ---
>  src/lxc/lxc_init.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/src/lxc/lxc_init.c b/src/lxc/lxc_init.c
> index c83c2f1..e4c9a32 100644
> --- a/src/lxc/lxc_init.c
> +++ b/src/lxc/lxc_init.c
> @@ -49,15 +49,14 @@ static struct option options[] = {
>  
>  static	int was_interrupted = 0;
>  
> -int main(int argc, char *argv[])
> +static void interrupt_handler(int sig)
>  {
> +	if (!was_interrupted)
> +		was_interrupted = sig;
> +}
>  
> -	void interrupt_handler(int sig)
> -	{
> -		if (!was_interrupted)
> -			was_interrupted = sig;
> -	}
> -
> +int main(int argc, char *argv[])
> +{
>  	pid_t pid;
>  	int nbargs = 0;
>  	int err = -1;
> -- 
> 1.8.1.4
>