[lxc-devel] [PATCH 2/2] lxc-attach: Implement --clear-env and --keep-env

Serge Hallyn serge.hallyn at ubuntu.com
Mon Apr 1 19:37:17 UTC 2013


Quoting Ward, David - 0663 - MITLL (david.ward at ll.mit.edu):
> On 03/30/2013 10:45 AM, Christian Seiler wrote:
> >This patch introduces the --clear-env and --keep-env options for
> >lxc-attach, that allows the user to specify whether the environment
> >should be passed on inside the container or not.
> >
> >This is to be expanded upon in later versions, this patch only
> >introduces the most basic functionality.
> >
> >Signed-off-by: Christian Seiler <christian-+GPkE3DhqnY at public.gmane.org>
> 
> The original intent of my earlier patch was to avoid different
> default behavior between lxc-execute and lxc-attach.  That no longer
> holds.  Can we apply these same changes below to lxc-execute please?

As I said somewhere in the thread, we'll want to use common code for
environment setting for those.  However, we took the patch for
lxc-attach now only because it was breaking a current use case for
Christian in v0.9.  Now for 1.0 we can pursue the right approach for
both.  If you and Christian want to work together on that, all the
better.

-serge




More information about the lxc-devel mailing list