[lxc-devel] [PATCH 2/2] lxc-attach: Implement --clear-env and --keep-env

[Christian Seiler]

Hi Serge,

> Right I'm not objecting to the arguments being passed, but I'm 
> wondering
> why he specifically has:
>
>> > > +	(void) extra_env;
>> > > +	(void) extra_keep;
>
> in the function there.

In order to suppress warnings from the compiler about unused arguments.
These lines suppress those warnings, stating to the compiler "Yes, I
know that the arguments are unused, but I currently want it that way."
Now obviously you can compile lxc without those warnings activated,
but distributions may override this, causing the build logs to be
uselessly bloated. (Obviously, a single occurrence doesn't matter that
much, but I try to do this in every function where for some valid
reason I don't use all the arguments.)

Of course, those lines will disappear post 0.9, once these options are
actually implemented. (As to the meaning of the options, I don't have
anything to add to Michael's explanation.)

-- Christian