[lxc-devel] [PATCH 2/3] lxc-pkgconfig-dir

[Stéphane Graber]

On 12-09-10 10:59 AM, Stéphane Graber wrote:
> On 12-09-10 10:46 AM, Daniel P. Berrange wrote:
>> On Mon, Sep 10, 2012 at 10:39:39AM -0400, Stéphane Graber wrote:
>>> On 12-09-10 10:28 AM, Dwight Engen wrote:
>>>> Put pkg-config .pc file in libdir.
>>>>
>>>> Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
>>>> ---
>>>>  Makefile.am |    2 +-
>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/Makefile.am b/Makefile.am
>>>> index 887e300..c66ecc6 100644
>>>> --- a/Makefile.am
>>>> +++ b/Makefile.am
>>>> @@ -6,7 +6,7 @@ SUBDIRS = src templates doc
>>>>  DIST_SUBDIRS = config src templates doc
>>>>  EXTRA_DIST = autogen.sh lxc.spec CONTRIBUTING MAINTAINERS ChangeLog
>>>>  
>>>> -pcdatadir = $(datadir)/pkgconfig
>>>> +pcdatadir = $(libdir)/pkgconfig
>>>>  pcdata_DATA = lxc.pc
>>>>  
>>>>  ChangeLog::
>>>
>>> What's the reason for that change?
>>>
>>> I believe both locations are allowed in pkg-config and at least on
>>> Debian systems, /usr/share/pkgconfig is more popular, so unless there's
>>> a very good reason for that change, I'm against it.
>>
>> The .pc files in /usr/share/pkgconfig must not refer to files that
>> live in /usr/lib. If they do, then they must go in /usr/lib/pkgconfig
>> This is so that you can install multiple arch versions of the
>> libraries concurrently. eg both 32 & 64 bit versions
>>
>> Daniel
> 
> Hmm, indeed that makes sense. The Ubuntu packaging should probably then
> make sure these actually end up in a multi-arch path
> (/usr/lib/<triplet/pkgconfig/).
> 
> Looks good then.
> 
> Acked-by: Stéphane Graber <stgraber at ubuntu.com>

Pushed to staging branch.

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 897 bytes
Desc: OpenPGP digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20120910/291d9c09/attachment.pgp>