[lxc-devel] [PATCH] make install should create $LXCPATH directory

[Dwight Engen]

On Thu, 29 Nov 2012 16:37:21 -0500
Stéphane Graber <stgraber at ubuntu.com> wrote:

> On 11/29/2012 04:24 PM, Dwight Engen wrote:
> > The $LXCPATH (default /var/lib/lxc) directory was not being created
> > by make install, so unless it gets created by some other means
> > (packaging tools), commands such as lxc-create will fail.
> > 
> > Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
> 
> Is the same already done for /var/cache/lxc or is that also missing?

Yes, it is also missing. It looks like this directory is used by some
of the templates, a v2 patch follows :) That led me to look into uses
of hardcoded "/var": Some places already use @LOCALSTATEDIR@ but some
don't, I've fixed those up as well in a seperate patch.

> > ---
> >  Makefile.am | 3 +++
> >  lxc.spec.in | 1 +
> >  2 files changed, 4 insertions(+)
> > 
> > diff --git a/Makefile.am b/Makefile.am
> > index f99ad1c..863f8fd 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -9,6 +9,9 @@ EXTRA_DIST = autogen.sh lxc.spec CONTRIBUTING
> > MAINTAINERS ChangeLog pcdatadir = $(libdir)/pkgconfig
> >  pcdata_DATA = lxc.pc
> >  
> > +install-data-local:
> > +	$(MKDIR_P) $(DESTDIR)$(LXCPATH)
> > +
> >  ChangeLog::
> >  	@touch ChangeLog
> >  
> > diff --git a/lxc.spec.in b/lxc.spec.in
> > index 3f4d5b6..bc69d68 100644
> > --- a/lxc.spec.in
> > +++ b/lxc.spec.in
> > @@ -97,6 +97,7 @@ rm -rf %{buildroot}
> >  %defattr(-,root,root)
> >  %{_libdir}/*.so.*
> >  %{_libdir}/%{name}
> > + at LXCPATH@
> >  %attr(4555,root,root) %{_libexecdir}/%{name}/lxc-init
> >  
> >  %files devel
> > 
> 
>