[lxc-devel] [PATCH] Include lxc-ubuntu when doing make dist

[Dwight Engen]

On Thu, 29 Nov 2012 13:31:41 -0500
Stéphane Graber <stgraber at ubuntu.com> wrote:

> On 11/29/2012 01:27 PM, Dwight Engen wrote:
> > Removing templates/lxc-ubuntu from configure.ac makes it so that it
> > is not included in the tarball that make dist builds (and therefore
> > also breaks the rpm build).
> > 
> > Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
> > ---
> >  templates/Makefile.am | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/templates/Makefile.am b/templates/Makefile.am
> > index 523498d..9a94f32 100644
> > --- a/templates/Makefile.am
> > +++ b/templates/Makefile.am
> > @@ -1,3 +1,5 @@
> > +EXTRA_DIST=lxc-ubuntu
> > +
> >  templatesdir=@LXCTEMPLATEDIR@
> >  
> >  templates_SCRIPTS = \
> > 
> 
> Oh, I should remember to test make dist. I only tried a make install
> and as it worked here, I assumed that the change was correct.
> 
> Is it the only file that's included in make install but not in make
> dist? (just wondering if I made that mistake somewhere else :)).

I only noticed because make rpm complained about a missing file :)
Since make rpm works with the above patch, that only means that all the
files that the rpm spec calls for (explicitly) were found, but I guess
there could be some others missing where the rpm spec has wildcards and
the dist list is different than what make install does.

> Acked-by: Stéphane Graber <stgraber at ubuntu.com>
>