[lxc-devel] [PATCH] Fix build with --enable-tests on Fedora

[Stéphane Graber]

On 11/29/2012 10:24 AM, Serge Hallyn wrote:
> Quoting Dwight Engen (dwight.engen at oracle.com):
>> When using --enable-tests on Fedora, the linker complains with:
>> "undefined reference to symbol sem_getvalue", which nm shows to be in
>> libpthread not librt. Build tested on Fedora, Oracle Linux, and Ubuntu.
>>
>> Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
> 
> Drat, sounds like there's a bug in sem_getvalue(3) manpage, which says
> 
> "Link with -lrt or -pthread."
> 
> Thanks.
> 
> Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>

Acked-by: Stéphane Graber <stgraber at ubuntu.com>

Applied to staging. Thanks

>> ---
>>  src/tests/Makefile.am |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/tests/Makefile.am b/src/tests/Makefile.am
>> index f4e4a5a..fa61f70 100644
>> --- a/src/tests/Makefile.am
>> +++ b/src/tests/Makefile.am
>> @@ -1,6 +1,6 @@
>>  if ENABLE_TESTS
>>  
>> -LDADD = ../lxc/liblxc.so -lrt
>> +LDADD = ../lxc/liblxc.so -lpthread
>>  lxc_test_containertests_SOURCES = containertests.c
>>  lxc_test_locktests_SOURCES = locktests.c
>>  lxc_test_startone_SOURCES = startone.c
>> -- 
>> 1.7.1
>>
>>
>> ------------------------------------------------------------------------------
>> Keep yourself connected to Go Parallel: 
>> INSIGHTS What's next for parallel hardware, programming and related areas?
>> Interviews and blogs by thought leaders keep you ahead of the curve.
>> http://goparallel.sourceforge.net
>> _______________________________________________
>> Lxc-devel mailing list
>> Lxc-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/lxc-devel
> 
> ------------------------------------------------------------------------------
> Keep yourself connected to Go Parallel: 
> VERIFY Test and improve your parallel project with help from experts 
> and peers. http://goparallel.sourceforge.net
> _______________________________________________
> Lxc-devel mailing list
> Lxc-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/lxc-devel
> 


-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20121129/5ed8ba12/attachment.pgp>