[lxc-devel] [PATCH 2/4] lxc-ubuntu: Guess a list of langpacks to install

[Stéphane Graber]

On 11/29/2012 10:18 AM, Serge Hallyn wrote:
> Quoting Stéphane Graber (stgraber at ubuntu.com):
>> On 11/29/2012 09:49 AM, Serge Hallyn wrote:
>>> Quoting Stéphane Graber (stgraber at ubuntu.com):
>>>> In addition to creating the current locale in the container, also
>>>> try to scan the host and extra the list of langpacks installed there,
>>>> then pass that list to debootstrap as additional packages to install.
>>>>
>>>> On distros that don't have dpkg, only language-pack-en will be installed.
>>>> The code will always ensure that language-pack-en is ALWAYS installed in the
>>>> target, similar to what Ubuntu does with its various media.
>>>>
>>>> Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
>>>> ---
>>>>  templates/lxc-ubuntu.in | 12 ++++++++++++
>>>>  1 file changed, 12 insertions(+)
>>>>
>>>> diff --git a/templates/lxc-ubuntu.in b/templates/lxc-ubuntu.in
>>>> index c9d4649..ce1e065 100644
>>>> --- a/templates/lxc-ubuntu.in
>>>> +++ b/templates/lxc-ubuntu.in
>>>> @@ -174,6 +174,18 @@ download_ubuntu()
>>>>      release=$3
>>>>  
>>>>      packages=vim,ssh
>>>> +
>>>> +    # Try to guess a list of langpacks to install
>>>> +    langpacks="language-pack-en"
>>>> +
>>>> +    if which dpkg >/dev/null 2>&1; then
>>>> +        langpacks=`(echo $LANGPACK_LIST &&
>>>
>>> Where does this LANGPACK_LIST come from?
>>
>> Doh, I should have been more careful when renaming variables :)
>>
>> Anyway, I fixed it now and sent the fix to lxc-devel, good catch!
> 
> Another question, do we definately want this?  I sort of prefer
> to keep the containers more minimal by default.  The default
> langpack is needed to avoid funkiness over ssh, but the others
> seem like perhaps more than is needed?

So, the problem is that ssh appears to forward LANG to the server, which
will lead to encoding problems if a matching locale doesn't exist.

Installing the same langpacks as the host will guarantee that ssh from
the host to the container won't ever give you weird encoding problems.

On all english systems, my code will only install language-pack-en, on
systems using a different locale, it'll install language-pack-en and the
language-pack-<LANGUAGE CODE>, so it shouldn't be a huge waste of space.

>>>> +                    dpkg -l | grep -E "^ii  language-pack-[a-z]* " |
>>>> +                        cut -d ' ' -f3) | sort -u`
>>>> +    fi
>>>> +    packages="$packages,$(echo $langpacks | sed 's/ /,/g')"
>>>> +
>>>> +
>>>>      echo "installing packages: $packages"
>>>>  
>>>>      trap cleanup EXIT SIGHUP SIGINT SIGTERM
>>>> -- 
>>>> 1.8.0
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Keep yourself connected to Go Parallel: 
>>>> INSIGHTS What's next for parallel hardware, programming and related areas?
>>>> Interviews and blogs by thought leaders keep you ahead of the curve.
>>>> http://goparallel.sourceforge.net
>>>> _______________________________________________
>>>> Lxc-devel mailing list
>>>> Lxc-devel at lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/lxc-devel
>>
>>
>> -- 
>> Stéphane Graber
>> Ubuntu developer
>> http://www.ubuntu.com
>>
> 
> 
> 
>> ------------------------------------------------------------------------------
>> Keep yourself connected to Go Parallel: 
>> VERIFY Test and improve your parallel project with help from experts 
>> and peers. http://goparallel.sourceforge.net
> 
>> _______________________________________________
>> Lxc-devel mailing list
>> Lxc-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/lxc-devel
> 


-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20121129/fdf2e48e/attachment.pgp>