[lxc-devel] [PATCH 3/4] lxc-ubuntu: Rename from lxc-ubuntu.in

Serge Hallyn serge.hallyn at canonical.com
Thu Nov 29 15:20:23 UTC 2012


Quoting Stéphane Graber (stgraber at ubuntu.com):
> On 11/29/2012 09:52 AM, Serge Hallyn wrote:
> > Quoting Stéphane Graber (stgraber at ubuntu.com):
> >> lxc-ubuntu no longer uses any build time variables, therefore it can
> >> now be simply copied to the target without any autoconf magic.
> >>
> >> Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
> > 
> > I'm trusting rather than verifying that the contents of
> > lxc-ubuntu are identical to lxc-ubuntu.in?  :)
> 
> Hehe, yeah, was just a simple "git mv", I wish git could somehow
> indicate that in the diff...

There is a way with some git format-patch flag or other, actually,
but I never remembe which.  -M?

> > It could certainly be argued that it's preferable to handle
> > all the templates the same way.  What would you say is the
> > advantage of doing this?
> 
> The main advantage for me is that when I see a template ending with .in
> I do a full local test build and then try the template locally as it's
> supposed to contain variables.
> If it doesn't, I just run lxc-create -t <path> and I save a good 5
> minutes :)

ok.

Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>

thanks,
-serge




More information about the lxc-devel mailing list