[lxc-devel] [PATCH] lxc-create: fix passing over first argument to template script

[Stéphane Graber]

On 11/22/2012 08:16 AM, Natanael Copa wrote:
> The e60a8164c12d565f70071ff6b32b823dd495df9e introduced a bug that caused
> first argument passed over to the template script get lost.
> 
> This patch fixes it.
> 
> Signed-off-by: Natanael Copa <ncopa at alpinelinux.org>
> ---
>  src/lxc/lxc-create.in | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/lxc/lxc-create.in b/src/lxc/lxc-create.in
> index e8056e9..26ec6a2 100644
> --- a/src/lxc/lxc-create.in
> +++ b/src/lxc/lxc-create.in
> @@ -137,7 +137,6 @@ while [ $# -gt 0 ]; do
>  		shift
>  		;;
>              --)
> -		shift
>  		break;;
>  	    -?)
>  		usage_err "unknown option '$opt'"
> 


That's indeed an issue, on top of this, there's also that problem:

root at castiana:~/Desktop/casper/casper# lxc-create -t ubuntu -n p1 --
--arch i386
/usr/bin/lxc-create: 87: local: not in a function

It looks like "local" isn't posix shell according to a bit of googling.

That's when running under Ubuntu and Debian's default shell, dash.

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20121122/cd929986/attachment.pgp>