[lxc-devel] Please make "-f" mandatory in lxc-create

[Serge Hallyn]

Quoting richard -rw- weinberger (richard.weinberger at gmail.com):
> On Tue, May 29, 2012 at 10:36 AM, richard -rw- weinberger
> <richard.weinberger at gmail.com> wrote:
> > Found the problem, patch is in the way!
> >
> 
> *grr*, forgot that this list is moderated.
> 
> --
> 
> Using this patch is it possible to catch usage errors like:
> lxc-create -n foo foo.cfg
> 
> Signed-off-by: Richard Weinberger <richard at nod.at>

That's good, thanks.

Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>

> ---
>  src/lxc/lxc-create.in |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/lxc/lxc-create.in b/src/lxc/lxc-create.in
> index bd9a438..89f0889 100644
> --- a/src/lxc/lxc-create.in
> +++ b/src/lxc/lxc-create.in
> @@ -136,6 +136,12 @@ while true; do
>          esac
>  done
> 
> +if [ ! -z "$1" ] ; then
> +    echo "Unknown argument: $1"
> +    usage
> +    exit 1
> +fi
> +
>  if [ -z "$lxc_path" ]; then
>      echo "$(basename $0): no configuration path defined" >&2
>      exit 1
> -- 
> 1.7.9.2
> 
> -- 
> Thanks,
> //richard
> 
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and 
> threat landscape has changed and how IT managers can respond. Discussions 
> will include endpoint security, mobile security and the latest in malware 
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Lxc-devel mailing list
> Lxc-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/lxc-devel