[lxc-devel] [PATCH] lxc-wait: Add timeout option

Serge Hallyn serge.hallyn at canonical.com
Mon Jul 9 19:16:08 UTC 2012


Quoting Jan Kiszka (jan.kiszka at siemens.com):
> On 2012-07-09 19:28, Serge Hallyn wrote:
> > Quoting Jan Kiszka (jan.kiszka at siemens.com):
> >> Allow to specify a timeout for waiting on state changes via lxc-wait.
> >> Helpful for scripts that need to handle errors or excessive delays in
> >> state changing procedures.
> > 
> > Hi,
> > 
> > in our lxc-api tree (https://code.launchpad.net/~ubuntu-lxc/ubuntu/quantal/lxc/lxc-api-and-python/)
> > I've added changed src/lxc/state.c:lxc_wait() to take an optional
> > timeout value (0 means don't wait, -1 means wait forever), and use
> > select, to implement wait with timeout.  It is only used by our
> > lxc_container->wait, not by src/lxc/lxc_wait.c which in our tree
> > passes in -1 to wait forever.  Ideally our patches would be combined.
> 
> No problem, I can base mine on top of yours. Did you post it already?

No I hadn't posted mine yet.  Until the API goes in it didn't have a
user...

Sorry, I think I was being silly.  Let's ignore what I said before.
Let's push your patch for now and I'll just have yours use mine if/when
mine goes up.

Acked-by: Serge E. Hallyn <serge at hallyn.com>

thanks,
-serge




More information about the lxc-devel mailing list